new calendar endpoints | part 4/4 | endpoint implementations #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint_Template::template_include() expects string, false given.
…dpoints\Endpoint.
carstingaxion
changed the title
8 tasks
…cts array<string>|string|WP_Post, int given.
…() does not exist.
…ubtype of Throwable
Preview changes with PlaygroundYou can preview the recent changes for PR#955 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
carstingaxion
commented
Oct 25, 2024
Comment on lines
+466
to
+492
| // Update permalink structure to '/%postname%/'. | ||
| update_option( 'permalink_structure', '/%postname%/' ); | ||
|
|
||
| // Reload the global rewrite rules object to ensure it reflects the changes. | ||
| global $wp_rewrite; | ||
| $wp_rewrite->init(); | ||
| flush_rewrite_rules(); | ||
|
|
||
| $output = $event->get_calendar_links(); | ||
| $expects = array( | ||
| 'google' => array( | ||
| 'name' => 'Google Calendar', | ||
| 'link' => home_url( '/event/unit-test-event/google-calendar' ), | ||
| ), | ||
| 'ical' => array( | ||
| 'name' => 'iCal', | ||
| 'download' => home_url( '/event/unit-test-event/ical' ), | ||
| ), | ||
| 'outlook' => array( | ||
| 'name' => 'Outlook', | ||
| 'download' => home_url( '/event/unit-test-event/outlook' ), | ||
| ), | ||
| 'yahoo' => array( | ||
| 'name' => 'Yahoo Calendar', | ||
| 'link' => home_url( '/event/unit-test-event/yahoo-calendar' ), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
I tried to change the permalink settings here, but failed.
I wanted to test the rewritten and the ugly permalinks in the same test.
Why did my attempts not work (within the tests)?
Comment on lines
+795
to
+826
| /** | ||
| * @author Stephen Harris (@stephenharris) | ||
| * @source https://github.com/stephenharris/Event-Organiser/blob/develop/includes/event-organiser-utility-functions.php#L1663 | ||
| * | ||
| * Fold text as per [iCal specifications](http://www.ietf.org/rfc/rfc2445.txt) | ||
| * | ||
| * Lines of text SHOULD NOT be longer than 75 octets, excluding the line | ||
| * break. Long content lines SHOULD be split into a multiple line | ||
| * representations using a line "folding" technique. That is, a long | ||
| * line can be split between any two characters by inserting a CRLF | ||
| * immediately followed by a single linear white space character (i.e., | ||
| * SPACE, US-ASCII decimal 32 or HTAB, US-ASCII decimal 9). Any sequence | ||
| * of CRLF followed immediately by a single linear white space character | ||
| * is ignored (i.e., removed) when processing the content type. | ||
| * | ||
| * @ignore | ||
| * @since 2.7 | ||
| * @param string $text The string to be escaped. | ||
| * @return string The escaped string. | ||
| */ | ||
| private static function eventorganiser_fold_ical_text( string $text ): string { | ||
|
|
||
| $text_arr = array(); | ||
|
|
||
| $lines = ceil( mb_strlen( $text ) / 75 ); | ||
|
|
||
| for ( $i = 0; $i < $lines; $i++ ) { | ||
| $text_arr[ $i ] = mb_substr( $text, $i * 75, 75 ); | ||
| } | ||
|
|
||
| return join( "\r\n ", $text_arr ); | ||
| } |
There was a problem hiding this comment.
I brazenly stole this code, because I knew it is working for years and I also knew that I couldn't do better.
But I don't just want to pirate Stephen Harris' code, without proper attribution - or rewriting it!
|
Hello @mauteri , can you please help me getting this finished? Would be nice to get your feedback or help or both! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the final part of the fragmentation of #831, which was way too big to review or merge.
I try to do better in the future.
Description of the Change
This PR introduces the following of new endpoints:
example.org/event/my-sample-event/icalprovides a download-able .ics file in ical format.
example.org/event/my-sample-event/outlookprovides the same download-able file as an alias.
example.org/event/my-sample-event/google-calendarredirects to create a new event in Google Calendar.
example.org/event/my-sample-event/yahoo-calendarredirects to create a new event in Yahoo Calendar.
example.org/event/feed/icalprovides a subscribe-able event feed in ical format with all events of the site.
example.org/venue/my-sample-venue/feed/icalprovides a subscribe-able event feed in ical format with all events at that venue.
example.org/topic/my-sample-topic/feed/icalprovides a subscribe-able event feed in ical format with all events grouped into that topic.
How to test the Change
echo ‚hello themed iCal world‘;into itChangelog Entry
Credits
Props @carstingaxion
Checklist:
Related PRs that can be reviewed & merged after this:
To get the new endpoints into the block-editor, one of the following would be required:
OR